Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favourites Mode #1366

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Favourites Mode #1366

wants to merge 2 commits into from

Conversation

KrahJohlito
Copy link
Member

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

This adds a new favourites mode, turn it on in settings highlight a game hit R3 and it will add it to the favourites page (or remove it if its already on there) and create a file on cwd so your list saves for subsequent boots.. adding another mode to enable in settings pushed stuff off screen so I had to add scrolling to the dialog windows.

favourites

Personal note: I know I have a bit open atm which may lead to some conflicts but I really need to get back to having my full focus on my studies so I've opened everything I've been working on recently and that works, if you want something take it; if there's conflicts later I can likely spare a few minutes to fix it or someone else is welcome to do so but for now I wish you all well and will see you another time :-)

Best regards

@KrahJohlito
Copy link
Member Author

force pushed to fix some codacy warnings, the rest are false positive imo.. memalign to 64 bytes works better for ps2 than malloc afair from what sp193 told me years ago

@Wolf3s
Copy link
Contributor

Wolf3s commented Nov 20, 2024

force pushed to fix some codacy warnings, the rest are false positive imo.. memalign to 64 bytes works better for ps2 than malloc afair from what sp193 told me years ago

aligned_alloc seems be a better solution nowadays than memalign since it's standardized and it can check memory better and it's present on C11

@israpps
Copy link
Member

israpps commented Nov 20, 2024

force pushed to fix some codacy warnings, the rest are false positive imo.. memalign to 64 bytes works better for ps2 than malloc afair from what sp193 told me years ago

depends on what you wanna do.

If data transfer from/into the IOP is involved alignment is important

@Wolf3s
Copy link
Contributor

Wolf3s commented Nov 20, 2024

force pushed to fix some codacy warnings, the rest are false positive imo.. memalign to 64 bytes works better for ps2 than malloc afair from what sp193 told me years ago

depends on what you wanna do.

If data transfer from/into the IOP is involved alignment is important

I tried posix_memalign which is suposely a upgrade version of memalign and didn't work

add favourites marking in real time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants